<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118661/">https://git.reviewboard.kde.org/r/118661/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 11th, 2014, 11 a.m. CEST, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you do this we need checks around building everything that tries to link against it otherwise you get mystery compile fails.
There's 2 applets and 9 KCMs</pre>
</blockquote>
<p>On June 11th, 2014, 11:06 a.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">they should already have these checks otherwise the check for X11 is kind of pointless.</pre>
</blockquote>
<p>On June 11th, 2014, 11:10 a.m. CEST, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I haven't checked all of them, but the TaskManager applet doesn't look to check.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* applets/pager: if(NOT WIN32) and if(KF5Activities_FOUND) - should be fine
* applets/taskmanager: if(NOT WIN32) - should be fine
* kcm/access: if(NOT WIN32) - should be fine
* kcm/bell: if(NOT WIN32) - should be fine
* kcm/colors: if(X11_FOUND) around X11Extras, but broken nevertheless as unconditionally linking to X11Libraries
* kcm/componentchoser: if(X11_FOUND)
* kcm/fonts: if(X11_FOUND)
* kcm/input: broken
* kcm/keyboard: if(X11_Xkb_FOUND AND XCB_XKB_FOUND)
* kcm/kfontinst: if(FONTCONFIG_FOUND AND FREETYPE_FOUND AND NOT WIN32)
* kcm/style: broken</pre>
<br />
<p>- Martin</p>
<br />
<p>On June 11th, 2014, 10:44 a.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 11, 2014, 10:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only find Qt5::X11Extras if X11 is found</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(399de771e17b265c1e5a223ad128ae2d17c00d22)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118661/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>