Review Request 114566: Plasmate: Port remoteinstaller to Qt5/KF5

David Edmundson david at davidedmundson.co.uk
Thu Jan 30 14:52:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114566/#review48627
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Jan. 5, 2014, 5:36 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114566/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2014, 5:36 p.m.)
> 
> 
> Review request for Plasma and Giorgos Tsiapaliokas.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> Hello,
> 
> This patch ports the remoteinstaller to Qt5/KF5.
> 
> 
> Diffs
> -----
> 
>   plasmate/CMakeLists.txt 55e7453 
>   plasmate/publisher/remoteinstaller/remoteinstaller.cpp 5f4de97 
>   plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp 3b41b33 
> 
> Diff: https://git.reviewboard.kde.org/r/114566/diff/
> 
> 
> Testing
> -------
> 
> I wasn't able to test if it works. Because remoteinstaller is using the KUrlRequester,
> which it segfaults... I have open a thread on the frameworks ML.
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140130/da61a199/attachment.html>


More information about the Plasma-devel mailing list