Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks

[Antonis Tsiapaliokas]

> On Dec. 16, 2013, 1:46 p.m., Sebastian Kügler wrote:
> > plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml, line 36
> > <https://git.reviewboard.kde.org/r/114493/diff/2/?file=225340#file225340line36>
> >
> >     Does this button actually do anything? :)

Right now, no. But it will show the konsole previewer when it will be ready.
Should i remove it/comment it?


> On Dec. 16, 2013, 1:46 p.m., Sebastian Kügler wrote:
> > plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml, line 40
> > <https://git.reviewboard.kde.org/r/114493/diff/2/?file=225340#file225340line40>
> >
> >     Does this button do anything?

same as above


> On Dec. 16, 2013, 1:46 p.m., Sebastian Kügler wrote:
> > plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml, line 105
> > <https://git.reviewboard.kde.org/r/114493/diff/2/?file=225341#file225341line105>
> >
> >     here, location() as function call looks weird, make it setLocation()

it should be changeLocation. Since this is our signal. Right?


> On Dec. 16, 2013, 1:46 p.m., Sebastian Kügler wrote:
> > plasmoidviewer/view.h, line 40
> > <https://git.reviewboard.kde.org/r/114493/diff/2/?file=225342#file225342line40>
> >
> >     setFormFactor(), change* indicates a from-to change, not the case here.
> >

We cannot rename this method to setFormFactor,
because then we will hide the src/plasma/containment.h: void setFormFactor(Plasma::Types::FormFactor formFactor);


> On Dec. 16, 2013, 1:46 p.m., Sebastian Kügler wrote:
> > plasmoidviewer/view.h, line 41
> > <https://git.reviewboard.kde.org/r/114493/diff/2/?file=225342#file225342line41>
> >
> >     setLocation

same as above


- Antonis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114493/#review45779
-----------------------------------------------------------


On Dec. 23, 2013, 1:25 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114493/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2013, 1:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> This is a merge request for plasmoidviewer2 branch into the frameworks branch.
> 
> Plasmoidviewer2 branch contains some missing features and bug fixes.
> 
> 
> Diffs
> -----
> 
>   plasmate/CMakeLists.txt 55e7453 
>   plasmate/publisher/remoteinstaller/remoteinstaller.cpp 5f4de97 
>   plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp 3b41b33 
> 
> Diff: https://git.reviewboard.kde.org/r/114493/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140105/9eaed77e/attachment.html>