Review Request 114566: Plasmate: Port remoteinstaller to Qt5/KF5

Antonis Tsiapaliokas kok3rs at gmail.com
Sun Jan 5 17:36:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114566/
-----------------------------------------------------------

(Updated Jan. 5, 2014, 5:36 p.m.)


Review request for Plasma and Giorgos Tsiapaliokas.


Changes
-------

Hello,

I have fix all the issues that they have been pointed out.


Repository: plasmate


Description
-------

Hello,

This patch ports the remoteinstaller to Qt5/KF5.


Diffs (updated)
-----

  plasmate/CMakeLists.txt 55e7453 
  plasmate/publisher/remoteinstaller/remoteinstaller.cpp 5f4de97 
  plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp 3b41b33 

Diff: https://git.reviewboard.kde.org/r/114566/diff/


Testing
-------

I wasn't able to test if it works. Because remoteinstaller is using the KUrlRequester,
which it segfaults... I have open a thread on the frameworks ML.


Thanks,

Antonis Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140105/459f1d8f/attachment.html>


More information about the Plasma-devel mailing list