Review Request 115224: Remove unused property drawWallpaper

[David Edmundson]

> On Jan. 22, 2014, 2:32 p.m., Marco Martin wrote:
> > well, actually ContainmentInterface of the qml scruiptengine does use it, to store wether loading and draw a wallpaper or not.
> > 
> > The issue is to keep it in Containment, or having it only in ContaimentInterface.
> > Either choice is fine with me... 
> > Personally i would limit the amount of api that is only in containmentinterface and not containment (basically the concept now is that Applet and Containment are models for appletintterface/containmentinterface)
> 
> Sebastian Kügler wrote:
>     I agree. appletinterface and containmentinterface should stay as small as possible and only have things in there that are specific for the QtQuick implementation. That reduces boilerplate and keeps Plasma::Applet and Plasma::Containment useful.
> 
> David Edmundson wrote:
>     Why would a containment not want to draw a wallpaper?
> 
> Marco Martin wrote:
>     depends from the shell's decision, not really from the containment itself, for instance panels are containments but won't have wallpapers.
>     
>     also, if the "dashboard with own containment" feature is kept or will return, it would be a normal desktop containment but wothout a wallpaper.

OK, thanks.

I'll restore it in the containment interface and make it a private bool there.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115224/#review48028
-----------------------------------------------------------


On Jan. 22, 2014, 2:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115224/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 2:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Remove unused property drawWallpaper
> 
> As suggested here: http://community.kde.org/Plasma/libplasma2/API_Review/Containment
> kde-workspace doesn't use it.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/plasmaquickview.cpp 03fe00e 
>   src/scriptengines/qml/plasmoid/containmentinterface.h 0ed5868 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 23edb67 
>   src/plasma/containment.h 1d747c6 
>   src/plasma/containment.cpp 590402a 
>   src/plasma/corona.cpp 9a937b0 
>   src/plasma/private/containment_p.h 597f26e 
>   src/plasma/scripting/appletscript.h 65301d4 
>   src/plasma/scripting/appletscript.cpp cb9df7d 
> 
> Diff: https://git.reviewboard.kde.org/r/115224/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140122/acc285af/attachment.html>