Review Request 115224: Remove unused property drawWallpaper

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115224/
-----------------------------------------------------------

(Updated Jan. 22, 2014, 4:54 p.m.)


Review request for Plasma.


Changes
-------

>depends from the shell's decision, not really from the containment itself, for instance panels are containments but won't have wallpapers.

We may as well move that in here then. That logic was in plasma view, where we altered a property on the root object which we then use in loadWallpaper();

>also, if the "dashboard with own containment" feature is kept or will return, it would be a normal desktop containment but wothout a wallpaper.

containment->setWallpaper(QString()); will remove it.


Repository: plasma-framework


Description
-------

Remove unused property drawWallpaper

As suggested here: http://community.kde.org/Plasma/libplasma2/API_Review/Containment
kde-workspace doesn't use it.


Diffs (updated)
-----

  src/plasma/containment.h 1d747c6 
  src/plasma/containment.cpp 590402a 
  src/plasma/corona.cpp 9a937b0 
  src/plasma/private/containment_p.h 597f26e 
  src/plasma/scripting/appletscript.h 65301d4 
  src/plasma/scripting/appletscript.cpp cb9df7d 
  src/plasmaquick/plasmaquickview.cpp 03fe00e 
  src/scriptengines/qml/plasmoid/containmentinterface.h 0ed5868 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 23edb67 

Diff: https://git.reviewboard.kde.org/r/115224/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140122/a2e157f9/attachment-0001.html>