<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115224/">https://git.reviewboard.kde.org/r/115224/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 22nd, 2014, 2:32 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well, actually ContainmentInterface of the qml scruiptengine does use it, to store wether loading and draw a wallpaper or not.
The issue is to keep it in Containment, or having it only in ContaimentInterface.
Either choice is fine with me...
Personally i would limit the amount of api that is only in containmentinterface and not containment (basically the concept now is that Applet and Containment are models for appletintterface/containmentinterface)</pre>
</blockquote>
<p>On January 22nd, 2014, 2:42 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree. appletinterface and containmentinterface should stay as small as possible and only have things in there that are specific for the QtQuick implementation. That reduces boilerplate and keeps Plasma::Applet and Plasma::Containment useful.</pre>
</blockquote>
<p>On January 22nd, 2014, 3:07 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why would a containment not want to draw a wallpaper?</pre>
</blockquote>
<p>On January 22nd, 2014, 3:10 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">depends from the shell's decision, not really from the containment itself, for instance panels are containments but won't have wallpapers.
also, if the "dashboard with own containment" feature is kept or will return, it would be a normal desktop containment but wothout a wallpaper.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, thanks.
I'll restore it in the containment interface and make it a private bool there.</pre>
<br />
<p>- David</p>
<br />
<p>On January 22nd, 2014, 2:24 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2014, 2:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove unused property drawWallpaper
As suggested here: http://community.kde.org/Plasma/libplasma2/API_Review/Containment
kde-workspace doesn't use it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/plasmaquickview.cpp <span style="color: grey">(03fe00e)</span></li>
<li>src/scriptengines/qml/plasmoid/containmentinterface.h <span style="color: grey">(0ed5868)</span></li>
<li>src/scriptengines/qml/plasmoid/containmentinterface.cpp <span style="color: grey">(23edb67)</span></li>
<li>src/plasma/containment.h <span style="color: grey">(1d747c6)</span></li>
<li>src/plasma/containment.cpp <span style="color: grey">(590402a)</span></li>
<li>src/plasma/corona.cpp <span style="color: grey">(9a937b0)</span></li>
<li>src/plasma/private/containment_p.h <span style="color: grey">(597f26e)</span></li>
<li>src/plasma/scripting/appletscript.h <span style="color: grey">(65301d4)</span></li>
<li>src/plasma/scripting/appletscript.cpp <span style="color: grey">(cb9df7d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115224/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>