Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks

Antonis Tsiapaliokas kok3rs at gmail.com
Sun Jan 5 18:49:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114493/
-----------------------------------------------------------

(Updated Jan. 5, 2014, 6:49 p.m.)


Review request for Plasma.


Changes
-------

Hello,

Here is the list of the issues that i have fix.

*Add QStringLiteral to as a parameter to changeLocation and
changeFormFactor methods.
*Fix typos
*Add missing const
*Rename locate => changeLocation and formFactor => changeFormFactor
signals


Repository: plasmate


Description
-------

This is a merge request for plasmoidviewer2 branch into the frameworks branch.

Plasmoidviewer2 branch contains some missing features and bug fixes.


Diffs (updated)
-----

  plasmoidviewer/CMakeLists.txt 30de8e2 
  plasmoidviewer/fullview.h 7d4c70d 
  plasmoidviewer/fullview.cpp 898931a 
  plasmoidviewer/main.cpp c913c38 
  plasmoidviewer/qmlpackages/containment/Messages.sh c8a9b60 
  plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js 62e149a 
  plasmoidviewer/qmlpackages/containment/contents/config/main.xml d889999 
  plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml b23e098 
  plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml 33d72c0 
  plasmoidviewer/qmlpackages/containment/contents/ui/main.qml 6558710 
  plasmoidviewer/qmlpackages/containment/metadata.desktop 9ddd217 
  plasmoidviewer/qmlpackages/shell/contents/applet/CompactApplet.qml e8e5caa 
  plasmoidviewer/qmlpackages/shell/contents/views/Background.qml PRE-CREATION 
  plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml e5bedf3 
  plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml PRE-CREATION 
  plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml PRE-CREATION 
  plasmoidviewer/view.h 0e2e48c 
  plasmoidviewer/view.cpp fc008b0 

Diff: https://git.reviewboard.kde.org/r/114493/diff/


Testing
-------


Thanks,

Antonis Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140105/9de17602/attachment-0001.html>


More information about the Plasma-devel mailing list