<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114493/">https://git.reviewboard.kde.org/r/114493/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>


<p style="color: grey;"><i>Updated Jan. 5, 2014, 6:49 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello,

Here is the list of the issues that i have fix.

*Add QStringLiteral to as a parameter to changeLocation and
changeFormFactor methods.
*Fix typos
*Add missing const
*Rename locate => changeLocation and formFactor => changeFormFactor
signals
</pre>
  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a merge request for plasmoidviewer2 branch into the frameworks branch.

Plasmoidviewer2 branch contains some missing features and bug fixes.</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmoidviewer/CMakeLists.txt <span style="color: grey">(30de8e2)</span></li>

 <li>plasmoidviewer/fullview.h <span style="color: grey">(7d4c70d)</span></li>

 <li>plasmoidviewer/fullview.cpp <span style="color: grey">(898931a)</span></li>

 <li>plasmoidviewer/main.cpp <span style="color: grey">(c913c38)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/Messages.sh <span style="color: grey">(c8a9b60)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js <span style="color: grey">(62e149a)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/contents/config/main.xml <span style="color: grey">(d889999)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml <span style="color: grey">(b23e098)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml <span style="color: grey">(33d72c0)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/contents/ui/main.qml <span style="color: grey">(6558710)</span></li>

 <li>plasmoidviewer/qmlpackages/containment/metadata.desktop <span style="color: grey">(9ddd217)</span></li>

 <li>plasmoidviewer/qmlpackages/shell/contents/applet/CompactApplet.qml <span style="color: grey">(e8e5caa)</span></li>

 <li>plasmoidviewer/qmlpackages/shell/contents/views/Background.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml <span style="color: grey">(e5bedf3)</span></li>

 <li>plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmoidviewer/view.h <span style="color: grey">(0e2e48c)</span></li>

 <li>plasmoidviewer/view.cpp <span style="color: grey">(fc008b0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114493/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>