Review Request 115870: The plasma-media center displays the time in AM between 12 noon and 1pm.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115870/#review50210
-----------------------------------------------------------



mediaelements/mediawelcome/HomeScreenFooter.qml
<https://git.reviewboard.kde.org/r/115870/#comment35345>

    This code is wrong (even without the patch), as it doesn't take the time format into account. Well, it tries to, but doesn't succeed.
    
    The problem is not entirely trivial, and it would probably make sense to do this from C++, at least for Qt4/Plasma 1, since QtQuick's machinery for displaying the local time isn't that great, really.


- Sebastian Kügler


On Feb. 19, 2014, 11:11 a.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115870/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 11:11 a.m.)
> 
> 
> Review request for Plasma and Sinny Kumari.
> 
> 
> Bugs: 330115 and Bug
>     http://bugs.kde.org/show_bug.cgi?id=330115
>     http://bugs.kde.org/show_bug.cgi?id=Bug
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> I just happened to run the plasma-mediacenter in the noon (between 12-1) and to my surprise I found the time being displayed as "0:11 AM" . But when I run it now , it displays the time properly.
> 
> Reproducible: Didn't try
> 
> Steps to Reproduce:
> 1.Run the plasma-mediacenter 
> 2.Check the time being displayed 
> 3.The time displayed will most likely be wrong between 12 noon to 1 pm .
> Actual Results:  
> I just encountered this error once so far . I'll have to wait 24 hours to see if the error persists .
> 
> Expected Results:  
> Should display the time as 12:11PM instead of 0:11AM.
> 
> The output of "lsb_release -a" : http://pastebin.kde.org/p4v5s1srq
> 
> The output of "uname -a" : http://pastebin.kde.org/pcncndtwb
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
> 
> Diff: https://git.reviewboard.kde.org/r/115870/diff/
> 
> 
> Testing
> -------
> 
> after creating the patch , the following steps were carried out
> 
> 1.cmake .. -DCMAKE_INSTALL_PREFIX=`kde4-config --prefix`
> 2.sudo make install
> 
> Change the clock to a time in between 12noon and 1pm and run the plasma-mediacenter.
> 
> The time displays properly ! 
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140219/1a36332f/attachment.html>