<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115870/">https://git.reviewboard.kde.org/r/115870/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115870/diff/1/?file=244791#file244791line47" style="color: black; font-weight: bold; text-decoration: underline;">mediaelements/mediawelcome/HomeScreenFooter.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span> <span class="nx">headerTimeText</span><span class="p">.</span><span class="nx">text</span> <span class="o">=</span> <span class="nx">hours</span> <span class="o">+</span> <span class="s1">':'</span> <span class="o">+</span> <span class="nx">minutes</span> <span class="o">+</span> <span class="s1">' '</span> <span class="o">+</span> <span class="nx">timeOfDay</span><span class="p">;</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span> <span class="nx">headerTimeText</span><span class="p">.</span><span class="nx">text</span> <span class="o">=</span> <span class="nx">hours</span> <span class="o">+</span> <span class="s1">':'</span> <span class="o">+</span> <span class="nx">minutes</span> <span class="o">+</span> <span class="s1">' '</span> <span class="o">+</span> <span class="nx">timeOfDay</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This code is wrong (even without the patch), as it doesn't take the time format into account. Well, it tries to, but doesn't succeed.
The problem is not entirely trivial, and it would probably make sense to do this from C++, at least for Qt4/Plasma 1, since QtQuick's machinery for displaying the local time isn't that great, really.</pre>
</div>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On February 19th, 2014, 11:11 a.m. UTC, R.Harish Navnit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Sinny Kumari.</div>
<div>By R.Harish Navnit.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2014, 11:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=330115">330115</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=Bug">Bug</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just happened to run the plasma-mediacenter in the noon (between 12-1) and to my surprise I found the time being displayed as "0:11 AM" . But when I run it now , it displays the time properly.
Reproducible: Didn't try
Steps to Reproduce:
1.Run the plasma-mediacenter
2.Check the time being displayed
3.The time displayed will most likely be wrong between 12 noon to 1 pm .
Actual Results:
I just encountered this error once so far . I'll have to wait 24 hours to see if the error persists .
Expected Results:
Should display the time as 12:11PM instead of 0:11AM.
The output of "lsb_release -a" : http://pastebin.kde.org/p4v5s1srq
The output of "uname -a" : http://pastebin.kde.org/pcncndtwb</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">after creating the patch , the following steps were carried out
1.cmake .. -DCMAKE_INSTALL_PREFIX=`kde4-config --prefix`
2.sudo make install
Change the clock to a time in between 12noon and 1pm and run the plasma-mediacenter.
The time displays properly ! </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediawelcome/HomeScreenFooter.qml <span style="color: grey">(d2c0eb7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115870/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>