Review Request 119687: Proposal for systemloadviewer configuration

[Martin Yrjölä]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119687/
-----------------------------------------------------------

(Updated Aug. 16, 2014, 9:26 a.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: kdeplasma-addons


Description
-------

I would be grateful for some pointers regarding the implementation so far.

- Can I somehow make the color choosing reusable? Now I have to write almost 50 lines of repetitive code for each color.
- Are there any suggestions regarding the design and usability? Now it's just a Label and a colored Rectangle, which opens a ColorDialog when clicked on. Is there any standard way of implementing color settings?
- Is Reviewboard the correct place for this kind of discussion?


Diffs
-----

  applets/systemloadviewer/package/contents/config/config.qml PRE-CREATION 
  applets/systemloadviewer/package/contents/config/main.xml PRE-CREATION 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml PRE-CREATION 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119687/diff/


Testing
-------

![Screenshot](http://i.imgur.com/YwcPYli.png)


Thanks,

Martin Yrjölä

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140816/1c687c1f/attachment-0001.html>