Review Request 119687: Proposal for systemloadviewer configuration

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119687/#review64128
-----------------------------------------------------------


>- Can I somehow make the color choosing reusable? Now I have to write almost 50 lines of repetitive code for each color.

Make the colour choosing part a component. (i.e a new file ColourChooser.qml)
Add a property for the chosen colour.

Then create a few instances of the component, and bind the property to the config.

>- Are there any suggestions regarding the design and usability? Now it's just a Label and a colored Rectangle, which opens a ColorDialog when clicked on. Is there any standard way of implementing color settings?

We have a design group on the forum https://forum.kde.org/viewforum.php?f=285. you can create a new thread or comment in my plasma-addons one.
They do tend to get a bit easily excited, so you'll need to keep them under control a bit :)

>- Is Reviewboard the correct place for this kind of discussion?

It can be. As long as the other people are here too, which is the hard part.

- David Edmundson


On Aug. 9, 2014, 8:19 p.m., Martin Yrjölä wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119687/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2014, 8:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> I would be grateful for some pointers regarding the implementation so far.
> 
> - Can I somehow make the color choosing reusable? Now I have to write almost 50 lines of repetitive code for each color.
> - Are there any suggestions regarding the design and usability? Now it's just a Label and a colored Rectangle, which opens a ColorDialog when clicked on. Is there any standard way of implementing color settings?
> - Is Reviewboard the correct place for this kind of discussion?
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/package/contents/config/config.qml PRE-CREATION 
>   applets/systemloadviewer/package/contents/config/main.xml PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119687/diff/
> 
> 
> Testing
> -------
> 
> ![Screenshot](http://i.imgur.com/YwcPYli.png)
> 
> 
> Thanks,
> 
> Martin Yrjölä
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140809/1559c281/attachment-0001.html>