Review Request 117455: [kglobalaccel] Remove Component::showKCM

[Martin Gräßlin]

> On April 14, 2014, 1:25 p.m., Aleix Pol Gonzalez wrote:
> > You can port it to QProcess as well, no?
> 
> Martin Gräßlin wrote:
>     Yes, but why? What would be the use case for having it? It's rather useless, isn't it?
> 
> Aleix Pol Gonzalez wrote:
>     It's public API... either way, go for it if you deem necessary, won't oppose either.
> 
> Martin Gräßlin wrote:
>     maybe I'm missing something, but it doesn't look like public API to me.
> 
> Aleix Pol Gonzalez wrote:
>     I guess that it's Q_SCRIPTABLE because it's accessible via DBus.
> 
> Aleix Pol Gonzalez wrote:
>     But well, if what kglobalaccel is just launching kcmshell5, the user of the API can just do it like that as well...

> I guess that it's Q_SCRIPTABLE because it's accessible via DBus.

that's what I thought when I started working on it (and why I checked with lxr). But when I removed the notification support I noticed that the showKCM() slot was introduced together with the notification support for the action (see git commit 708c8f68). Nothing in the commit points to that this should be useable through DBus and it looks to me like it was made scriptable because all other slots are scriptable.

And yes whether one opens the KCM through dbus or through launching kcmshell5 doesn't make a difference and there are no users anyway.

Do I get a ShipIt? ;-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/#review55699
-----------------------------------------------------------


On April 9, 2014, 7:05 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117455/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 7:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [kglobalaccel] Remove Component::showKCM
> 
> Component::showKCM was a method exported to DBus to wrap the invocation
> of "kcmshell5 keys".
> 
> According to lxr there is no application using this DBus method and it's
> not much use anyway as it doesn't open the keys KCM for the component.
> 
> This removes the KIOWidgets dependency from kglobalaccel.
> 
> 
> Diffs
> -----
> 
>   kglobalaccel/CMakeLists.txt b77f85edab091fd260fb9bddb1ddb43df445c5fe 
>   kglobalaccel/component.h 019c315374ecd226cb0820519a76bdbc3ced678c 
>   kglobalaccel/component.cpp 72a4980a3c26140bde692d376338da03dc67086e 
> 
> Diff: https://git.reviewboard.kde.org/r/117455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140414/1d8d7346/attachment.html>