<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117455/">https://git.reviewboard.kde.org/r/117455/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 14th, 2014, 1:25 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can port it to QProcess as well, no?</pre>
</blockquote>
<p>On April 14th, 2014, 1:31 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, but why? What would be the use case for having it? It's rather useless, isn't it?</pre>
</blockquote>
<p>On April 14th, 2014, 2:22 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's public API... either way, go for it if you deem necessary, won't oppose either.</pre>
</blockquote>
<p>On April 14th, 2014, 2:26 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">maybe I'm missing something, but it doesn't look like public API to me.</pre>
</blockquote>
<p>On April 14th, 2014, 2:47 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess that it's Q_SCRIPTABLE because it's accessible via DBus.</pre>
</blockquote>
<p>On April 14th, 2014, 2:47 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But well, if what kglobalaccel is just launching kcmshell5, the user of the API can just do it like that as well...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> I guess that it's Q_SCRIPTABLE because it's accessible via DBus.
that's what I thought when I started working on it (and why I checked with lxr). But when I removed the notification support I noticed that the showKCM() slot was introduced together with the notification support for the action (see git commit 708c8f68). Nothing in the commit points to that this should be useable through DBus and it looks to me like it was made scriptable because all other slots are scriptable.
And yes whether one opens the KCM through dbus or through launching kcmshell5 doesn't make a difference and there are no users anyway.
Do I get a ShipIt? ;-)</pre>
<br />
<p>- Martin</p>
<br />
<p>On April 9th, 2014, 7:05 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 9, 2014, 7:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[kglobalaccel] Remove Component::showKCM
Component::showKCM was a method exported to DBus to wrap the invocation
of "kcmshell5 keys".
According to lxr there is no application using this DBus method and it's
not much use anyway as it doesn't open the keys KCM for the component.
This removes the KIOWidgets dependency from kglobalaccel.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kglobalaccel/CMakeLists.txt <span style="color: grey">(b77f85edab091fd260fb9bddb1ddb43df445c5fe)</span></li>
<li>kglobalaccel/component.h <span style="color: grey">(019c315374ecd226cb0820519a76bdbc3ced678c)</span></li>
<li>kglobalaccel/component.cpp <span style="color: grey">(72a4980a3c26140bde692d376338da03dc67086e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117455/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>