Review Request 117455: [kglobalaccel] Remove Component::showKCM

[Aleix Pol Gonzalez]

> On April 14, 2014, 11:25 a.m., Aleix Pol Gonzalez wrote:
> > You can port it to QProcess as well, no?
> 
> Martin Gräßlin wrote:
>     Yes, but why? What would be the use case for having it? It's rather useless, isn't it?
> 
> Aleix Pol Gonzalez wrote:
>     It's public API... either way, go for it if you deem necessary, won't oppose either.
> 
> Martin Gräßlin wrote:
>     maybe I'm missing something, but it doesn't look like public API to me.
> 
> Aleix Pol Gonzalez wrote:
>     I guess that it's Q_SCRIPTABLE because it's accessible via DBus.

But well, if what kglobalaccel is just launching kcmshell5, the user of the API can just do it like that as well...


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/#review55699
-----------------------------------------------------------


On April 9, 2014, 5:05 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117455/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 5:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [kglobalaccel] Remove Component::showKCM
> 
> Component::showKCM was a method exported to DBus to wrap the invocation
> of "kcmshell5 keys".
> 
> According to lxr there is no application using this DBus method and it's
> not much use anyway as it doesn't open the keys KCM for the component.
> 
> This removes the KIOWidgets dependency from kglobalaccel.
> 
> 
> Diffs
> -----
> 
>   kglobalaccel/CMakeLists.txt b77f85edab091fd260fb9bddb1ddb43df445c5fe 
>   kglobalaccel/component.h 019c315374ecd226cb0820519a76bdbc3ced678c 
>   kglobalaccel/component.cpp 72a4980a3c26140bde692d376338da03dc67086e 
> 
> Diff: https://git.reviewboard.kde.org/r/117455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140414/67d44188/attachment-0001.html>