Review Request 117374: Add a kded module for ksysguard

[Aleix Pol Gonzalez]

> On April 5, 2014, 10:47 a.m., Aleix Pol Gonzalez wrote:
> > I wouldn't call the kded ksysguard too. We already have ksysguard repository and libksysguard...
> 
> Vishesh Handa wrote:
>     Would "KSysguard Launcher" be a better fit?
>     
>     diff --git a/ksysguard/kded_ksysguard.desktop b/ksysguard/kded_ksysguard.desktop
>     index ea2834f..4db315f 100644
>     --- a/ksysguard/kded_ksysguard.desktop
>     +++ b/ksysguard/kded_ksysguard.desktop
>     @@ -8,5 +8,5 @@ X-KDE-Kded-autoload=true
>      X-KDE-Kded-load-on-demand=false
>      X-KDE-Kded-phase=1
>     
>     -Name=KSysguard
>     +Name=KSysguard Launcher
>      Comment=Launches KSysguard on Ctrl + Escape
>

I was thinking of renaming the directory, more than the name within the desktop file.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117374/#review55023
-----------------------------------------------------------


On April 4, 2014, 2:45 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117374/
> -----------------------------------------------------------
> 
> (Updated April 4, 2014, 2:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
>     This module is responsible for launching the simple ksysguard module
>     that krunner used to show when pressing the "Ctrl + Escape" keyboard
>     shortcut.
> 
>     Most of this code used to exist in the old krunner
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8834986 
>   ksysguard/CMakeLists.txt PRE-CREATION 
>   ksysguard/kded_ksysguard.desktop PRE-CREATION 
>   ksysguard/kdedksysguard.h PRE-CREATION 
>   ksysguard/kdedksysguard.cpp PRE-CREATION 
>   ksysguard/ksystemactivitydialog.h PRE-CREATION 
>   ksysguard/ksystemactivitydialog.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117374/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140407/aad0988a/attachment.html>