<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117374/">https://git.reviewboard.kde.org/r/117374/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 5th, 2014, 10:47 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wouldn't call the kded ksysguard too. We already have ksysguard repository and libksysguard...</pre>
</blockquote>
<p>On April 7th, 2014, 9:21 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would "KSysguard Launcher" be a better fit?
diff --git a/ksysguard/kded_ksysguard.desktop b/ksysguard/kded_ksysguard.desktop
index ea2834f..4db315f 100644
--- a/ksysguard/kded_ksysguard.desktop
+++ b/ksysguard/kded_ksysguard.desktop
@@ -8,5 +8,5 @@ X-KDE-Kded-autoload=true
X-KDE-Kded-load-on-demand=false
X-KDE-Kded-phase=1
-Name=KSysguard
+Name=KSysguard Launcher
Comment=Launches KSysguard on Ctrl + Escape
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was thinking of renaming the directory, more than the name within the desktop file.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On April 4th, 2014, 2:45 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated April 4, 2014, 2:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> This module is responsible for launching the simple ksysguard module
that krunner used to show when pressing the "Ctrl + Escape" keyboard
shortcut.
Most of this code used to exist in the old krunner</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8834986)</span></li>
<li>ksysguard/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksysguard/kded_ksysguard.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksysguard/kdedksysguard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksysguard/kdedksysguard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksysguard/ksystemactivitydialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksysguard/ksystemactivitydialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117374/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>