Review Request 109641: Fix border detection in Plasma dialogs

Aleix Pol Gonzalez aleixpol at gmail.com
Thu Mar 21 14:01:03 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109641/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

I had some problems with plasma dialogs borders, they appeared arbitrarily.
After a good couple of hours of debugging, I found out that there was some really weird processing of the available region.

This patch removes this processing and uses QRegion itself to figure out if the border has to be painted. It seems to work fine.


Diffs
-----

  plasma/dialog.cpp 038444c 

Diff: http://git.reviewboard.kde.org/r/109641/diff/


Testing
-------

Played with it, together with the ktp-chat plasmoid


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130321/e7f1975c/attachment.html>


More information about the Plasma-devel mailing list