Review Request 109641: Fix border detection in Plasma dialogs

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109641/#review29641
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On March 21, 2013, 2:01 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109641/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 2:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I had some problems with plasma dialogs borders, they appeared arbitrarily.
> After a good couple of hours of debugging, I found out that there was some really weird processing of the available region.
> 
> This patch removes this processing and uses QRegion itself to figure out if the border has to be painted. It seems to work fine.
> 
> 
> Diffs
> -----
> 
>   plasma/dialog.cpp 038444c 
> 
> Diff: http://git.reviewboard.kde.org/r/109641/diff/
> 
> 
> Testing
> -------
> 
> Played with it, together with the ktp-chat plasmoid
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130321/4a72a1b0/attachment.html>