Review Request 111801: Minor fix in Local Browsing Search

[Sinny Kumari]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111801/#review36837
-----------------------------------------------------------

Ship it!



mediaelements/mediabrowser/MediaBrowser.qml
<http://git.reviewboard.kde.org/r/111801/#comment27171>

    keep opening curly brace in same line to if 
     if (event.text && searchMedia.visible) {
    
    we follow this convention



mediaelements/mediabrowser/MediaBrowser.qml
<http://git.reviewboard.kde.org/r/111801/#comment27172>

    else statement should be written in same line to closing curly brace of if 
    
    Syntax:
    
    if (condition) {
    // statement
    } else {
    // statement
    }


Works perfectly!

Ship it after fixing these small issues

- Sinny Kumari


On July 30, 2013, 6:12 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111801/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 6:12 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Removed a couple of unnecessary statements in the Local Files Model and fixed the extra white space fault when escape key is pressed in local browsing search.
> 
> 
> Diffs
> -----
> 
>   browsingbackends/localfiles/localfilesabstractbackend.cpp 1f3ac9b 
>   browsingbackends/localfiles/localfilesabstractmodel.cpp eb797d2 
>   mediaelements/mediabrowser/MediaBrowser.qml 42e4fa2 
> 
> Diff: http://git.reviewboard.kde.org/r/111801/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Sinny : Please see if the patch does not ruin the intention of your commit earlier in mediaBrowser and please check if the issue you pointed earlier gets solved.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130730/df4b1eef/attachment.html>