Review Request 111801: Minor fix in Local Browsing Search
Akshay Ratan
akshay_ratan at yahoo.com
Tue Jul 30 18:12:10 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111801/
-----------------------------------------------------------
(Updated July 30, 2013, 6:12 p.m.)
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Changes
-------
fixed indentations.
Description
-------
Removed a couple of unnecessary statements in the Local Files Model and fixed the extra white space fault when escape key is pressed in local browsing search.
Diffs (updated)
-----
browsingbackends/localfiles/localfilesabstractbackend.cpp 1f3ac9b
browsingbackends/localfiles/localfilesabstractmodel.cpp eb797d2
mediaelements/mediabrowser/MediaBrowser.qml 42e4fa2
Diff: http://git.reviewboard.kde.org/r/111801/diff/
Testing
-------
Yes.
Sinny : Please see if the patch does not ruin the intention of your commit earlier in mediaBrowser and please check if the issue you pointed earlier gets solved.
Thanks,
Akshay Ratan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130730/13c804c6/attachment.html>
More information about the Plasma-devel
mailing list