Review Request 111801: Minor fix in Local Browsing Search
Commit Hook
null at kde.org
Tue Jul 30 18:58:42 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111801/#review36838
-----------------------------------------------------------
This review has been submitted with commit 198a146e8784c9e08b0e3e60fff56be0d0630f0b by Akshay Ratan to branch akshay_localSearch.
- Commit Hook
On July 30, 2013, 6:12 p.m., Akshay Ratan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111801/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 6:12 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Description
> -------
>
> Removed a couple of unnecessary statements in the Local Files Model and fixed the extra white space fault when escape key is pressed in local browsing search.
>
>
> Diffs
> -----
>
> browsingbackends/localfiles/localfilesabstractbackend.cpp 1f3ac9b
> browsingbackends/localfiles/localfilesabstractmodel.cpp eb797d2
> mediaelements/mediabrowser/MediaBrowser.qml 42e4fa2
>
> Diff: http://git.reviewboard.kde.org/r/111801/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Sinny : Please see if the patch does not ruin the intention of your commit earlier in mediaBrowser and please check if the issue you pointed earlier gets solved.
>
>
> Thanks,
>
> Akshay Ratan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130730/d444eb83/attachment.html>
More information about the Plasma-devel
mailing list