Review Request 111691: Add KPluginFactory compatible ctor to dataengine

Sebastian Kügler sebas at kde.org
Thu Jul 25 16:03:26 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111691/
-----------------------------------------------------------

Review request for Plasma and Aaron J. Seigo.


Description
-------

This adds back a ctor that is useful for creating a KPluginFactory, which has the metadata baked into the plugin. With corresponding patches to kdelibs, this allows to create a dataengine, with valid KPluginInfo from a Qt plugin (i.e. without using KService)


Diffs
-----

  src/plasma/dataengine.h d3baad3 
  src/plasma/dataengine.cpp a2c68cb 
  src/plasma/private/dataengine_p.h d8ade83 

Diff: http://git.reviewboard.kde.org/r/111691/diff/


Testing
-------

Build and loaded plugin, verified metadata is completely inside KPluginInfo


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130725/06acdc97/attachment.html>


More information about the Plasma-devel mailing list