Review Request 111691: Add KPluginFactory compatible ctor to dataengine
Aaron J. Seigo
aseigo at kde.org
Thu Jul 25 16:45:47 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111691/#review36500
-----------------------------------------------------------
the QVariantList args is soooo ugly imho; wish there was a better way of doing this. in any case .. small comment below
src/plasma/dataengine.h
<http://git.reviewboard.kde.org/r/111691/#comment26939>
are the args also needed on this one?
- Aaron J. Seigo
On July 25, 2013, 4:03 p.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111691/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 4:03 p.m.)
>
>
> Review request for Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> This adds back a ctor that is useful for creating a KPluginFactory, which has the metadata baked into the plugin. With corresponding patches to kdelibs, this allows to create a dataengine, with valid KPluginInfo from a Qt plugin (i.e. without using KService)
>
>
> Diffs
> -----
>
> src/plasma/dataengine.h d3baad3
> src/plasma/dataengine.cpp a2c68cb
> src/plasma/private/dataengine_p.h d8ade83
>
> Diff: http://git.reviewboard.kde.org/r/111691/diff/
>
>
> Testing
> -------
>
> Build and loaded plugin, verified metadata is completely inside KPluginInfo
>
>
> Thanks,
>
> Sebastian Kügler
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130725/d9417486/attachment-0001.html>
More information about the Plasma-devel
mailing list