Review Request 108664: Remove absolute paths from Plasma/Generic packages

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108664/
-----------------------------------------------------------

(Updated Jan. 29, 2013, 8:07 p.m.)


Review request for Plasma, Marco Martin and Sebastian Kügler.


Changes
-------

updated patch fixes the case where there is a *bad* package in a more-local directory than a correct package.

it also simplifies the work Applet is doing in loading its packages now that this is all done where it should be: in Package.


Description
-------

This path gets rid of the absolute defaultRootPath for Plasma/Generic packages. to compensate for this change, it also introduces the ability for Package to handle relative paths properly, a bit more like what libplasma2 already does.

Without this, any Plasma/Generic packages installed in $HOME will render any system installed packages unreachable.


Diffs (updated)
-----

  plasma/applet.cpp 2f7fbdb 
  plasma/package.cpp 1a49531 
  plasma/packagestructure.cpp b66069c 
  plasma/private/package_p.h a572c12 

Diff: http://git.reviewboard.kde.org/r/108664/diff/


Testing
-------

packagestructuretest passes; plasmoidviewer still works (installed packages; relative paths; absolute paths); plasma-desktop functions correctly (activity manager and widgets explorer inc); more testing needed.

may require a full scan of all uses of Plasma/Generic packages :/


Thanks,

Aaron J. Seigo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130129/1633b608/attachment.html>