Review Request 108664: Remove absolute paths from Plasma/Generic packages
Aaron J. Seigo
aseigo at kde.org
Tue Jan 29 19:10:27 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108664/
-----------------------------------------------------------
Review request for Plasma, Marco Martin and Sebastian Kügler.
Description
-------
This path gets rid of the absolute defaultRootPath for Plasma/Generic packages. to compensate for this change, it also introduces the ability for Package to handle relative paths properly, a bit more like what libplasma2 already does.
Without this, any Plasma/Generic packages installed in $HOME will render any system installed packages unreachable.
Diffs
-----
plasma/package.cpp 1a49531
plasma/packagestructure.cpp b66069c
plasma/private/package_p.h a572c12
Diff: http://git.reviewboard.kde.org/r/108664/diff/
Testing
-------
packagestructuretest passes; plasmoidviewer still works (installed packages; relative paths; absolute paths); plasma-desktop functions correctly (activity manager and widgets explorer inc); more testing needed.
may require a full scan of all uses of Plasma/Generic packages :/
Thanks,
Aaron J. Seigo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130129/17550e6d/attachment.html>
More information about the Plasma-devel
mailing list