Review Request 108664: Remove absolute paths from Plasma/Generic packages

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108664/#review26386
-----------------------------------------------------------

Ship it!


Patch looks good, code *now* does what I'd expect it to.

I've tested it, and it fixes the issue.

A grep through my src checkouts reveals 29 uses of PackageStructure with Plasma/Generic, so the work to check it all seems possible (we'll have to do that anyway, at some point, moving to F5).

- Sebastian Kügler


On Jan. 29, 2013, 8:07 p.m., Aaron J. Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108664/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 8:07 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> This path gets rid of the absolute defaultRootPath for Plasma/Generic packages. to compensate for this change, it also introduces the ability for Package to handle relative paths properly, a bit more like what libplasma2 already does.
> 
> Without this, any Plasma/Generic packages installed in $HOME will render any system installed packages unreachable.
> 
> 
> Diffs
> -----
> 
>   plasma/applet.cpp 2f7fbdb 
>   plasma/package.cpp 1a49531 
>   plasma/packagestructure.cpp b66069c 
>   plasma/private/package_p.h a572c12 
> 
> Diff: http://git.reviewboard.kde.org/r/108664/diff/
> 
> 
> Testing
> -------
> 
> packagestructuretest passes; plasmoidviewer still works (installed packages; relative paths; absolute paths); plasma-desktop functions correctly (activity manager and widgets explorer inc); more testing needed.
> 
> may require a full scan of all uses of Plasma/Generic packages :/
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130129/4ff1f66c/attachment.html>