Review Request 114405: Remove Applet::Private::isContainment

David Edmundson david at davidedmundson.co.uk
Wed Dec 11 14:51:18 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114405/
-----------------------------------------------------------

(Updated Dec. 11, 2013, 2:51 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Marco Martin.


Repository: plasma-framework


Description
-------

Remove Applet::Private::isContainment

Instead determine by introspecting if this inherits from Containment


Diffs
-----

  src/plasma/applet.cpp f0630ac 
  src/plasma/containment.cpp 1b5be33 
  src/plasma/corona.cpp dc5865c 
  src/plasma/private/applet_p.h 65ec9aa 
  src/plasma/private/applet_p.cpp b9e68ba 

Diff: http://git.reviewboard.kde.org/r/114405/diff/


Testing
-------

Tests pass.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131211/481d0054/attachment.html>


More information about the Plasma-devel mailing list