Review Request 114405: Remove Applet::Private::isContainment
Commit Hook
null at kde.org
Wed Dec 11 14:51:13 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114405/#review45541
-----------------------------------------------------------
This review has been submitted with commit ef58fdbf6f8707daea4e5f0c142a90f971944098 by David Edmundson to branch master.
- Commit Hook
On Dec. 11, 2013, 12:45 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114405/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 12:45 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Remove Applet::Private::isContainment
>
> Instead determine by introspecting if this inherits from Containment
>
>
> Diffs
> -----
>
> src/plasma/applet.cpp f0630ac
> src/plasma/containment.cpp 1b5be33
> src/plasma/corona.cpp dc5865c
> src/plasma/private/applet_p.h 65ec9aa
> src/plasma/private/applet_p.cpp b9e68ba
>
> Diff: http://git.reviewboard.kde.org/r/114405/diff/
>
>
> Testing
> -------
>
> Tests pass.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131211/27fb3d30/attachment.html>
More information about the Plasma-devel
mailing list