QML style guide

Martin Gräßlin mgraesslin at kde.org
Tue Oct 30 17:27:52 UTC 2012


On Tuesday 30 October 2012 13:40:22 Sebastian Kügler wrote:
> On Tuesday, October 30, 2012 11:35:50 Aaron J. Seigo wrote:
> > > >> 5. Vim:
> > > >>> The {{{ and }}} are just for the sakes of vim's automatic folding.
> > > >> 
> > > >> Do we all use vim? I think no. So, we must never force developers use
> > > >> vim.
> > > > 
> > > > i mostly agree :) i don't think this forces anyone to use vim, but i
> > > > would
> > > > like to see a solution that works with katepart before adding it to
> > > > the
> > > > style guide.
> > > 
> > > Do you want force developers use kate?
> > 
> > of course not :)
> > 
> > but i'd like to make the lives of people who use kate, vim, etc. easier if
> > possible. if we have to chose between "no one benefits from code folding"
> > or  "some people get to benefit", we should pick "some people" every
> > single
> > time. "some" is better than "none".
> > 
> > this does not prevent you from using any editor you wish -> you might not
> > get  the cute little bonus of code folding, but otherwise it's the same as
> > it is right now already.
> 
> To be honest, I don't like that. I'm fine with people putting it in, but
> making it mandatory is not OK with me. I would not like to reject someone's
> patch based on "its properties aren't foldable in vim". First, this is 2013.
> Then, property definitions aren't usually pages long, I've rarely seen more
> than 10.
> 
> -1 one if it was the idea to mandate {{{ annd }}} in comments.
> 
> (Allowing it is fine with me, mandating is is not.)
Personally I'm even against allowing it go in at all. It just clutters the 
code. It's not our task to cover up bugs in editors. If vim doesn't handle it, 
vim should be fixed. Also given that I'm not a vim user I would not know how 
many }}}}}} I have to place at a position or whether I have to change them 
when moving code around.

Personally I also are against the Kate settings you find in some files. If 
someone needs that, that's fine with me, but it should not end up in the 
repository.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121030/6b0cde44/attachment.sig>


More information about the Plasma-devel mailing list