Review Request: Plasmate: Remove Python support for konsole previewer
Antonis Tsiapaliokas
kok3rs at gmail.com
Thu Nov 8 14:05:24 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107209/
-----------------------------------------------------------
(Updated Nov. 8, 2012, 2:05 p.m.)
Review request for Plasma.
Changes
-------
In this patch i have fix the issues which have been pointed out by sebas.
Also the detection of the API for our plasmoid should not be inside the setKonsoleVisible
so i move it to a new method.
Description
-------
Right now the python bindings doesn't support the kDebug, so the konsole previewer cannot return any output.
Until this is fixed, we are disabling the python support for the konsole previewer.
Diffs (updated)
-----
plasmate/mainwindow.h 6ac6fcd
plasmate/mainwindow.cpp 9c19658
plasmate/previewer/plasmoid/previewcontainment.h 34dfb52
plasmate/previewer/plasmoid/previewcontainment.cpp 266baa4
plasmate/previewer/previewer.h 271bab8
plasmate/previewer/previewer.cpp 6f07098
Diff: http://git.reviewboard.kde.org/r/107209/diff/
Testing
-------
Thanks,
Antonis Tsiapaliokas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121108/387eaddd/attachment.html>
More information about the Plasma-devel
mailing list