<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107209/">http://git.reviewboard.kde.org/r/107209/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2012, 2:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In this patch i have fix the issues which have been pointed out by sebas.
Also the detection of the API for our plasmoid should not be inside the setKonsoleVisible
so i move it to a new method.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right now the python bindings doesn't support the kDebug, so the konsole previewer cannot return any output.
Until this is fixed, we are disabling the python support for the konsole previewer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/mainwindow.h <span style="color: grey">(6ac6fcd)</span></li>
<li>plasmate/mainwindow.cpp <span style="color: grey">(9c19658)</span></li>
<li>plasmate/previewer/plasmoid/previewcontainment.h <span style="color: grey">(34dfb52)</span></li>
<li>plasmate/previewer/plasmoid/previewcontainment.cpp <span style="color: grey">(266baa4)</span></li>
<li>plasmate/previewer/previewer.h <span style="color: grey">(271bab8)</span></li>
<li>plasmate/previewer/previewer.cpp <span style="color: grey">(6f07098)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107209/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>