Review Request: Plasmate: Remove Python support for konsole previewer

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107209/#review21594
-----------------------------------------------------------

Ship it!


Three niggles, otherwise good to go. Please fix those, then feel free to commit.


plasmate/mainwindow.cpp
<http://git.reviewboard.kde.org/r/107209/#comment16771>

    It's actually "Console" in English, I think we had an overdose of KDE =)
    
    (It's ok to just fix the user visible string)



plasmate/previewer/plasmoid/previewcontainment.cpp
<http://git.reviewboard.kde.org/r/107209/#comment16773>

    Better compare it to its actual state, rather than its default state.



plasmate/previewer/plasmoid/previewcontainment.cpp
<http://git.reviewboard.kde.org/r/107209/#comment16772>

    remove that one before committing.


- Sebastian Kügler


On Nov. 7, 2012, 9:31 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107209/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 9:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Right now the python bindings doesn't support the kDebug, so the konsole previewer cannot return any output.
> Until this is fixed, we are disabling the python support for the konsole previewer.
> 
> 
> Diffs
> -----
> 
>   plasmate/mainwindow.h 6ac6fcd 
>   plasmate/mainwindow.cpp 9c19658 
>   plasmate/previewer/plasmoid/previewcontainment.h 34dfb52 
>   plasmate/previewer/plasmoid/previewcontainment.cpp 266baa4 
>   plasmate/previewer/previewer.h 271bab8 
>   plasmate/previewer/previewer.cpp 6f07098 
> 
> Diff: http://git.reviewboard.kde.org/r/107209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121107/fe4a5a50/attachment.html>