Review Request: Add Package bindings from MobileComponents to PlasmaCore

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107166/#review21281
-----------------------------------------------------------


the reason this is still in MobileComponent is because it isn't quite "general purpose use" ready. the biggest issue is that it always assumes a Plasma/Generic type and can not load from anywhere other than the normal system install paths.

properties for type and install root would probably fix that. with those properties, the package should not be created on setting the name, but when there is at least both package name and type. this could be problematic as to avoid creating packages and metadata types repeatedly, it should probably be done in a delayed fashion e.g. with a timer that is started whenever the properties change. a concern there then is that filePath will not return anything until that happens, so that also may not be workable.

it may even make sense to create the package in the filePath methods?

Marco probably has though this through a lot more as well .. 

also, a bool valid read-only property should be added.


plasma/declarativeimports/core/packageproxy.cpp
<http://git.reviewboard.kde.org/r/107166/#comment16589>

    these catalog insertions should probably be done in PackageStructure subclasses; not all packages will have i18n support


- Aaron J. Seigo


On Nov. 1, 2012, 12:24 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107166/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2012, 12:24 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add Package bindings from MobileComponents
> 
> This adds bindings for Plasma::Package to the PlasmaCore plugin.
> 
> This class has moved and been renamed from plasma-mobile's
> MobileComponents (Package -> PackageProxy, runtime-visible, it's just
> PlasmaCore.Package).
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/CMakeLists.txt bf4625c588d13f00da9bd9f72f0eec60cb889616 
>   plasma/declarativeimports/core/corebindingsplugin.cpp 755dad61ceee070d50c7731e14f284b89c0f8d30 
>   plasma/declarativeimports/core/packageproxy.h PRE-CREATION 
>   plasma/declarativeimports/core/packageproxy.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107166/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121101/249d19fb/attachment-0001.html>