<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107166/">http://git.reviewboard.kde.org/r/107166/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the reason this is still in MobileComponent is because it isn't quite "general purpose use" ready. the biggest issue is that it always assumes a Plasma/Generic type and can not load from anywhere other than the normal system install paths.
properties for type and install root would probably fix that. with those properties, the package should not be created on setting the name, but when there is at least both package name and type. this could be problematic as to avoid creating packages and metadata types repeatedly, it should probably be done in a delayed fashion e.g. with a timer that is started whenever the properties change. a concern there then is that filePath will not return anything until that happens, so that also may not be workable.
it may even make sense to create the package in the filePath methods?
Marco probably has though this through a lot more as well ..
also, a bool valid read-only property should be added.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107166/diff/1/?file=93164#file93164line56" style="color: black; font-weight: bold; text-decoration: underline;">plasma/declarativeimports/core/packageproxy.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PackageProxy::setName(const QString &name)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KGlobal</span><span class="o">::</span><span class="n">locale</span><span class="p">()</span><span class="o">-></span><span class="n">insertCatalog</span><span class="p">(</span><span class="s">"plasma_package_"</span> <span class="o">+</span> <span class="n">name</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">these catalog insertions should probably be done in PackageStructure subclasses; not all packages will have i18n support</pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On November 1st, 2012, 12:24 a.m., Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2012, 12:24 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add Package bindings from MobileComponents
This adds bindings for Plasma::Package to the PlasmaCore plugin.
This class has moved and been renamed from plasma-mobile's
MobileComponents (Package -> PackageProxy, runtime-visible, it's just
PlasmaCore.Package).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/core/CMakeLists.txt <span style="color: grey">(bf4625c588d13f00da9bd9f72f0eec60cb889616)</span></li>
<li>plasma/declarativeimports/core/corebindingsplugin.cpp <span style="color: grey">(755dad61ceee070d50c7731e14f284b89c0f8d30)</span></li>
<li>plasma/declarativeimports/core/packageproxy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/core/packageproxy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107166/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>