Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

Aurélien Gâteau agateau at kde.org
Thu May 24 09:50:56 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104973/
-----------------------------------------------------------

(Updated May 24, 2012, 9:50 a.m.)


Review request for kdelibs and Plasma.


Changes
-------

Subscribing Plasma as there are probably more people working on this class there.


Description
-------

When RunnerManager::reset() is called, all ThreadWeaver jobs are dequeued, including jobs from other parts of the code. This patch changes this to only dequeue the jobs created by this instance of RunnerManager.


Diffs
-----

  plasma/runnermanager.cpp 49569a3 

Diff: http://git.reviewboard.kde.org/r/104973/diff/


Testing
-------

I have more than one RunnerManager working at once in a project. Without the patch, only one manager return results.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120524/9eef7edd/attachment-0001.html>


More information about the Plasma-devel mailing list