Review Request: Fix behavior of "runners" property

Aurélien Gâteau agateau at kde.org
Thu May 24 11:53:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105024/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

This commit changes the behavior of the "runners" property when no manager has been created yet:
- Setting the property emits runnersChanged() (unless it is the same as the old value)
- Reading the property after setting it returns the new value


Diffs
-----

  plasma/declarativeimports/krunnermodel/runnermodel.cpp 2717ef8 

Diff: http://git.reviewboard.kde.org/r/105024/diff/


Testing
-------

Run attached test script. Without the patch, output is:
"""
runners before: 
runners after:
"""

With the patch one gets:
"""
runners before: 
onRunnersChanged(): runners=services,shell
runners after: services,shell
"""


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120524/55ae3c99/attachment.html>


More information about the Plasma-devel mailing list