Review Request: Fix the minimum size of some applets
Antonis Tsiapaliokas
kok3rs at gmail.com
Thu Jun 21 22:40:05 UTC 2012
> On June 14, 2012, 10:33 a.m., Aaron J. Seigo wrote:
> > applets/timer/timer.cpp, line 49
> > <http://git.reviewboard.kde.org/r/105234/diff/4/?file=67588#file67588line49>
> >
> > this will break it in smaller panels.
Also the indentation is not correct.
> On June 14, 2012, 10:33 a.m., Aaron J. Seigo wrote:
> > applets/weatherstation/weatherstation.cpp, line 37
> > <http://git.reviewboard.kde.org/r/105234/diff/4/?file=67589#file67589line37>
> >
> > breaks in smaller panels.
Also the indentation is not correct.
- Antonis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105234/#review14728
-----------------------------------------------------------
On June 13, 2012, 7:19 p.m., Maarten De Meyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105234/
> -----------------------------------------------------------
>
> (Updated June 13, 2012, 7:19 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This fixes the minimum size of the following applets: showdashboard, systemloadviewer, pastebin, weatherstation and timer.
> Some sizes were to small, so there were visual glitches and some applets had no minimum value set.
>
> I have no commit rights.
>
>
> Diffs
> -----
>
> applets/pastebin/pastebin.cpp 208e6a3
> applets/showdashboard/showdashboard.cpp 1c2f623
> applets/systemloadviewer/systemloadviewer.cpp b852256
> applets/timer/timer.cpp ba5ee66
> applets/weatherstation/weatherstation.cpp 8ada9c2
>
> Diff: http://git.reviewboard.kde.org/r/105234/diff/
>
>
> Testing
> -------
>
> Run the applets with their new minimum size, and minimized.
>
>
> Thanks,
>
> Maarten De Meyer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120621/8246f72f/attachment-0001.html>
More information about the Plasma-devel
mailing list