Review Request: Fix the minimum size of some applets

[Maarten De Meyer]

> On June 14, 2012, 10:33 a.m., Aaron J. Seigo wrote:
> > applets/pastebin/pastebin.cpp, line 263
> > <http://git.reviewboard.kde.org/r/105234/diff/4/?file=67585#file67585line263>
> >
> >     why 33?

As I explained to David:
"If it is 32 the iconSize() method (as I understand it) selects a smaller icon.
iconSize() returns the biggest fitting icon, if the rectangle is 32x32 the biggest fitting icon is 16x16. This looks way too small on the desktop and is not consistent with other applets.
If the rectangle is 1 pixel higher and wider it works and looks better."

However it still seems to select a smaller icon now anyway so I changed it.


> On June 14, 2012, 10:33 a.m., Aaron J. Seigo wrote:
> > applets/showdashboard/showdashboard.cpp, line 57
> > <http://git.reviewboard.kde.org/r/105234/diff/4/?file=67586#file67586line57>
> >
> >     why 22?

Because that looks good and is consistent with other applets (battery)
suggested by David Edmundson


- Maarten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105234/#review14728
-----------------------------------------------------------


On June 22, 2012, 6:17 a.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105234/
> -----------------------------------------------------------
> 
> (Updated June 22, 2012, 6:17 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This fixes the minimum size of the following applets: showdashboard, systemloadviewer, pastebin, weatherstation and timer.
> Some sizes were to small, so there were visual glitches and some applets had no minimum value set.
> 
> I have no commit rights.
> 
> 
> Diffs
> -----
> 
>   applets/pastebin/pastebin.cpp 208e6a3 
>   applets/showdashboard/showdashboard.h 695347f 
>   applets/showdashboard/showdashboard.cpp 1c2f623 
>   applets/systemloadviewer/systemloadviewer.cpp b852256 
>   applets/timer/timer.cpp ba5ee66 
>   applets/weatherstation/weatherstation.h 6d4ae24 
>   applets/weatherstation/weatherstation.cpp 8ada9c2 
> 
> Diff: http://git.reviewboard.kde.org/r/105234/diff/
> 
> 
> Testing
> -------
> 
> Run the applets with their new minimum size, and minimized.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120622/cd27fd72/attachment-0001.html>