Review Request: Fix the minimum size of some applets

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105234/#review14728
-----------------------------------------------------------


applets MUST be scalable down to smaller sizes, otherwise they break in small spaces such as panels. setting a minimum size in this fashion does not work as a result.


applets/pastebin/pastebin.cpp
<http://git.reviewboard.kde.org/r/105234/#comment11628>

    minimumSize needs to be reset here, otherwise it won't fit in panels smaller than the min size set below



applets/pastebin/pastebin.cpp
<http://git.reviewboard.kde.org/r/105234/#comment11629>

    why 33?



applets/showdashboard/showdashboard.cpp
<http://git.reviewboard.kde.org/r/105234/#comment11630>

    why 22?



applets/systemloadviewer/systemloadviewer.cpp
<http://git.reviewboard.kde.org/r/105234/#comment11627>

    incorrect indentation



applets/timer/timer.cpp
<http://git.reviewboard.kde.org/r/105234/#comment11631>

    this will break it in smaller panels.



applets/weatherstation/weatherstation.cpp
<http://git.reviewboard.kde.org/r/105234/#comment11632>

    breaks in smaller panels.


- Aaron J. Seigo


On June 13, 2012, 7:19 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105234/
> -----------------------------------------------------------
> 
> (Updated June 13, 2012, 7:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This fixes the minimum size of the following applets: showdashboard, systemloadviewer, pastebin, weatherstation and timer.
> Some sizes were to small, so there were visual glitches and some applets had no minimum value set.
> 
> I have no commit rights.
> 
> 
> Diffs
> -----
> 
>   applets/pastebin/pastebin.cpp 208e6a3 
>   applets/showdashboard/showdashboard.cpp 1c2f623 
>   applets/systemloadviewer/systemloadviewer.cpp b852256 
>   applets/timer/timer.cpp ba5ee66 
>   applets/weatherstation/weatherstation.cpp 8ada9c2 
> 
> Diff: http://git.reviewboard.kde.org/r/105234/diff/
> 
> 
> Testing
> -------
> 
> Run the applets with their new minimum size, and minimized.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120614/9a7b1635/attachment.html>