Review Request: Plasmate: Add QML Aurorae decoration support to the startpage

[Antonis Tsiapaliokas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105773/#review16579
-----------------------------------------------------------



startpage.cpp
<http://git.reviewboard.kde.org/r/105773/#comment12906>

    Should we change it to "Window Decoration"?



startpage.cpp
<http://git.reviewboard.kde.org/r/105773/#comment12907>

    Since the kcm_kwindecoration is using the "xorg" icon, i thought that also the plasmate should use it. What do you think?



startpage.cpp
<http://git.reviewboard.kde.org/r/105773/#comment12905>

    A new file, with the name of the project is being copied inside the $ProjectName/contents/code.... And i cannot find why... The files that are supposed to be copied are the qml/aurorae


- Antonis Tsiapaliokas


On July 28, 2012, 4:50 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105773/
> -----------------------------------------------------------
> 
> (Updated July 28, 2012, 4:50 p.m.)
> 
> 
> Review request for kwin, Plasma, Sebastian Kügler, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Hello,
> 
> With this patch i am adding the QML Aurorae decoration support to the startpage.
> Now the plasmate has a new entry on the startpage with name "KWin Decoration".
> Also it provides a new Aurorae decoration template with every new project.
> 
> @Martin The template doesn't simulate switching from active to inactive, clicking buttons etc etc. I will add that support among with the previewer.
> @Martin Please take a look at the inline comments...
> @ALL i have change the way that the values from the template ($AUTHOR,$EMAIL,$DATE etc) are being changed. What did you think? Did you find any issue?
> 
> 
> Diffs
> -----
> 
>   editors/metadata/metadataeditor.cpp 7dffc23 
>   mainwindow.cpp 1f1f28c 
>   startpage.h 30b2845 
>   startpage.cpp 726e43a 
>   templates/CMakeLists.txt d7acc81 
>   templates/qml/aurorae/AuroraeDecoration.qml PRE-CREATION 
>   templates/qml/aurorae/AuroraePreview.qml PRE-CREATION 
>   templates/qml/aurorae/DecorationPreview.qml PRE-CREATION 
>   templates/qml/aurorae/mainKWinDecoration.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120728/37fde121/attachment.html>