<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105773/">http://git.reviewboard.kde.org/r/105773/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105773/diff/1/?file=75114#file75114line148" style="color: black; font-weight: bold; text-decoration: underline;">startpage.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void StartPage::setupWidgets()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">148</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">new</span> <span class="n">QListWidgetItem</span><span class="p">(</span><span class="n">KIcon</span><span class="p">(</span><span class="s">"xorg"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"KWin Decoration"</span><span class="p">),</span> <span class="n">m_ui</span><span class="p">.</span><span class="n">contentTypes</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should we change it to "Window Decoration"?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105773/diff/1/?file=75114#file75114line350" style="color: black; font-weight: bold; text-decoration: underline;">startpage.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void StartPage::refreshRecentProjectsList()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">350</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">defaultIconName</span> <span class="o">=</span> <span class="s">"xorg"</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since the kcm_kwindecoration is using the "xorg" icon, i thought that also the plasmate should use it. What do you think?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105773/diff/1/?file=75114#file75114line472" style="color: black; font-weight: bold; text-decoration: underline;">startpage.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void StartPage::createNewProject()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">472</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">tmpFile</span><span class="p">.</span><span class="n">copy</span><span class="p">(</span><span class="n">projectPath</span> <span class="o">+</span> <span class="s">"/contents/code/"</span> <span class="o">+</span><span class="n">fileName</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A new file, with the name of the project is being copied inside the $ProjectName/contents/code.... And i cannot find why... The files that are supposed to be copied are the qml/aurorae</pre>
</div>
<br />
<p>- Antonis</p>
<br />
<p>On July 28th, 2012, 4:50 p.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin, Plasma, Sebastian Kügler, Aaron J. Seigo, and Martin Gräßlin.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated July 28, 2012, 4:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello,
With this patch i am adding the QML Aurorae decoration support to the startpage.
Now the plasmate has a new entry on the startpage with name "KWin Decoration".
Also it provides a new Aurorae decoration template with every new project.
@Martin The template doesn't simulate switching from active to inactive, clicking buttons etc etc. I will add that support among with the previewer.
@Martin Please take a look at the inline comments...
@ALL i have change the way that the values from the template ($AUTHOR,$EMAIL,$DATE etc) are being changed. What did you think? Did you find any issue?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>editors/metadata/metadataeditor.cpp <span style="color: grey">(7dffc23)</span></li>
<li>mainwindow.cpp <span style="color: grey">(1f1f28c)</span></li>
<li>startpage.h <span style="color: grey">(30b2845)</span></li>
<li>startpage.cpp <span style="color: grey">(726e43a)</span></li>
<li>templates/CMakeLists.txt <span style="color: grey">(d7acc81)</span></li>
<li>templates/qml/aurorae/AuroraeDecoration.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/qml/aurorae/AuroraePreview.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/qml/aurorae/DecorationPreview.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/qml/aurorae/mainKWinDecoration.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105773/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>