Review Request: Do not disable the "Delete" action after deleting one item

Jekyll Wu adaptee at gmail.com
Sun Jul 29 04:35:15 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105778/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

I fail to figure out from the existing code the intention of disabling the "Delete" action after deleting one item. Maybe for the edge case of the last item being deleted? But the patched code works well in that edge case, too.

The git history does not provide much hint. Those lines of disabling those actions were written and last updated almost ten year ago.


This addresses bug 296682.
    http://bugs.kde.org/show_bug.cgi?id=296682


Diffs
-----

  kmenuedit/treeview.cpp d0e6553 

Diff: http://git.reviewboard.kde.org/r/105778/diff/


Testing
-------

I haven't noticed any problem after applying this patch.


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120729/23174a4f/attachment.html>


More information about the Plasma-devel mailing list