Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

[Antonis Tsiapaliokas]

> On Aug. 27, 2012, 4:32 p.m., Sebastian Kügler wrote:
> > mainwindow.cpp, line 1026
> > <http://git.reviewboard.kde.org/r/106118/diff/3/?file=81728#file81728line1026>
> >
> >     Why not just } else { ?

Sorry for my late reply but i am/will be very busy for the following days.

Because we always want to clean the tmpFile and to add an objectName.

Also i done that for the consistency of the code. I thought that it would be better to look as much possible as it could with the "createPreviewerFor".


- Antonis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/#review18117
-----------------------------------------------------------


On Aug. 27, 2012, 4:06 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106118/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 4:06 p.m.)
> 
> 
> Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and Giorgos Tsiapaliwkas.
> 
> 
> Description
> -------
> 
> Hello,
> 
> This patch is adding the konsolepreviewer support to the KWin Scripts.
> When the user, is pressing the "Execute" button, then the script is being called.
> Also on the toolbar, there is a new action with name "konsole". This action is visible only when we are inside to a KWin Script.
> All the other packages, have a previewer. So the "konsole" action is located inside the previewer.
> 
> 
> Diffs
> -----
> 
>   konsole/konsolepreviewer.h 8dd4369 
>   konsole/konsolepreviewer.cpp c4f9f8b 
>   main.cpp 298be51 
>   mainwindow.h 8005d26 
>   mainwindow.cpp b84da4a 
>   plasmateui.rc b51884d 
>   publisher/remoteinstaller/remoteinstaller.cpp a54d453 
> 
> Diff: http://git.reviewboard.kde.org/r/106118/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> konsole
>   http://git.reviewboard.kde.org/r/106118/s/693/
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120829/5e50ee05/attachment-0001.html>