Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.
Sebastian Kügler
sebas at kde.org
Mon Aug 27 16:32:32 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/#review18117
-----------------------------------------------------------
Ship it!
Looking good now :)
mainwindow.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14355>
Why not just } else { ?
- Sebastian Kügler
On Aug. 27, 2012, 4:06 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106118/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2012, 4:06 p.m.)
>
>
> Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and Giorgos Tsiapaliwkas.
>
>
> Description
> -------
>
> Hello,
>
> This patch is adding the konsolepreviewer support to the KWin Scripts.
> When the user, is pressing the "Execute" button, then the script is being called.
> Also on the toolbar, there is a new action with name "konsole". This action is visible only when we are inside to a KWin Script.
> All the other packages, have a previewer. So the "konsole" action is located inside the previewer.
>
>
> Diffs
> -----
>
> konsole/konsolepreviewer.h 8dd4369
> konsole/konsolepreviewer.cpp c4f9f8b
> main.cpp 298be51
> mainwindow.h 8005d26
> mainwindow.cpp b84da4a
> plasmateui.rc b51884d
> publisher/remoteinstaller/remoteinstaller.cpp a54d453
>
> Diff: http://git.reviewboard.kde.org/r/106118/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> konsole
> http://git.reviewboard.kde.org/r/106118/s/693/
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120827/87987064/attachment-0001.html>
More information about the Plasma-devel
mailing list