Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

Antonis Tsiapaliokas kok3rs at gmail.com
Mon Aug 27 16:06:17 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/
-----------------------------------------------------------

(Updated Aug. 27, 2012, 4:06 p.m.)


Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and Giorgos Tsiapaliwkas.


Changes
-------

In this patch i am fixing the issues that they have pointed out by sebas.

@sebas for the hard coded strings, please take a look at my comment bellow..


Description
-------

Hello,

This patch is adding the konsolepreviewer support to the KWin Scripts.
When the user, is pressing the "Execute" button, then the script is being called.
Also on the toolbar, there is a new action with name "konsole". This action is visible only when we are inside to a KWin Script.
All the other packages, have a previewer. So the "konsole" action is located inside the previewer.


Diffs (updated)
-----

  konsole/konsolepreviewer.h 8dd4369 
  konsole/konsolepreviewer.cpp c4f9f8b 
  main.cpp 298be51 
  mainwindow.h 8005d26 
  mainwindow.cpp b84da4a 
  plasmateui.rc b51884d 
  publisher/remoteinstaller/remoteinstaller.cpp a54d453 

Diff: http://git.reviewboard.kde.org/r/106118/diff/


Testing
-------


Screenshots
-----------

konsole
  http://git.reviewboard.kde.org/r/106118/s/693/


Thanks,

Antonis Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120827/b9ec6e38/attachment.html>


More information about the Plasma-devel mailing list