Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/#review18087
-----------------------------------------------------------



konsole/konsolepreviewer.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14323>

    This should just reflect the global setting, we should not set this without very good reason inside the app, no?



konsole/konsolepreviewer.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14324>

    (Not your code, I get that ;))
    
    Here, we should not hardcode pathes, but take the temporary directory from KStandardDirs,  or at least QDir::temp()
    
    Could you change that as well?



konsole/konsolepreviewer.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14325>

    Add the specified filename, makes it easier for the user to fix the problem.



konsole/konsolepreviewer.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14326>

    Don't hardcode temporary dir, see above



mainwindow.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14321>

    This button should probably be checkabe as well, reflecting that it's actually a toggle action



mainwindow.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14322>

    Put the next two lines into an else, otherwise the code can become crashy (konsole == 0) when someone else adds a new project type.


- Sebastian Kügler


On Aug. 27, 2012, 7:18 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106118/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 7:18 a.m.)
> 
> 
> Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and Giorgos Tsiapaliwkas.
> 
> 
> Description
> -------
> 
> Hello,
> 
> This patch is adding the konsolepreviewer support to the KWin Scripts.
> When the user, is pressing the "Execute" button, then the script is being called.
> Also on the toolbar, there is a new action with name "konsole". This action is visible only when we are inside to a KWin Script.
> All the other packages, have a previewer. So the "konsole" action is located inside the previewer.
> 
> 
> Diffs
> -----
> 
>   konsole/konsolepreviewer.h 8dd4369 
>   konsole/konsolepreviewer.cpp c4f9f8b 
>   main.cpp 298be51 
>   mainwindow.h 8005d26 
>   mainwindow.cpp b84da4a 
>   plasmateui.rc b51884d 
> 
> Diff: http://git.reviewboard.kde.org/r/106118/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> konsole
>   http://git.reviewboard.kde.org/r/106118/s/693/
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120827/9a953182/attachment.html>