Review Request: Remove the signals from the constant properties

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104475/#review12401
-----------------------------------------------------------

Ship it!


- Marco Martin


On April 3, 2012, 11:10 a.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104475/
> -----------------------------------------------------------
> 
> (Updated April 3, 2012, 11:10 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> the KLocale QML bindings are almost ready(only two properties doesn't work) except from this issue.
> There are some properties which doesn't have a setter so I can't emit their signals. Also the KLocale/KCalendarSystem
> doesn't derive from QObject so I can't do any signal forward. Moreover the global config files doesn't give me any relative
> information regarding my issue. So I decided to remove the signals and make the properties constant. What do you think?
> 
> P.S.After I solve this issue I will add review for the whole branch.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/locale/calendarsystem.h 184a37e 
>   plasma/declarativeimports/locale/locale.h f52761e 
>   plasma/declarativeimports/locale/tests/contents/code/klocaleqmltest.qml 0e61bb3 
> 
> Diff: http://git.reviewboard.kde.org/r/104475/diff/
> 
> 
> Testing
> -------
> 
> everything works
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120413/00149fe5/attachment.html>