Review Request: Remove the signals from the constant properties

Giorgos Tsiapaliwkas terietor at gmail.com
Tue Apr 3 11:10:32 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104475/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Hello,

the KLocale QML bindings are almost ready(only two properties doesn't work) except from this issue.
There are some properties which doesn't have a setter so I can't emit their signals. Also the KLocale/KCalendarSystem
doesn't derive from QObject so I can't do any signal forward. Moreover the global config files doesn't give me any relative
information regarding my issue. So I decided to remove the signals and make the properties constant. What do you think?

P.S.After I solve this issue I will add review for the whole branch.


Diffs
-----

  plasma/declarativeimports/locale/calendarsystem.h 184a37e 
  plasma/declarativeimports/locale/locale.h f52761e 
  plasma/declarativeimports/locale/tests/contents/code/klocaleqmltest.qml 0e61bb3 

Diff: http://git.reviewboard.kde.org/r/104475/diff/


Testing
-------

everything works


Thanks,

Giorgos Tsiapaliwkas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120403/c5a6bccc/attachment.html>


More information about the Plasma-devel mailing list